-
Notifications
You must be signed in to change notification settings - Fork 11.2k
Open
Conversation
Returns an immutable map that iterates in sorted key order while still using hashing for lookups, as an alternative to ImmutableSortedMap's O(log N) lookups. The sort is stable, and duplicate keys are resolved in favor of the last value, matching buildKeepingLast(). RELNOTES=`collect`: Added `ImmutableMap.sortedCopyOf`, which returns an immutable map that is sorted by key.
Covers natural and comparator ordering, stability, null handling, and duplicate-key behavior (last value wins). RELNOTES=n/a
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
DerrickUnleashed
marked this pull request as ready for review
August 4, 2026 11:18
chytanvir1998-png
chytanvir1998-png
approved these changes
Aug 8, 2026
@cpovirk
cpovirk
added
type=enhancement
Make an existing feature better
package=collect
P3
no SLO
labels
Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8552.
Adds two overloads, matching the existing ImmutableList.sortedCopyOf pattern:
sortedCopyOf(Map)- sorts by natural key ordersortedCopyOf(Comparator, Map)- sorts by a given key comparatorThe result is a regular ImmutableMap (hashing-based lookups), just with entries iterating in sorted order - handy when you want deterministic iteration without the
O(log N)lookups of ImmutableSortedMap.Behaviour notes:
Builder.buildKeepingLast().Also includes a GWT super-source implementation and tests.